fix: add missing showNativeManageAgentsWindow stub for non-darwin platforms#7
Closed
kevinelliott wants to merge 6 commits into
Closed
fix: add missing showNativeManageAgentsWindow stub for non-darwin platforms#7kevinelliott wants to merge 6 commits into
kevinelliott wants to merge 6 commits into
Conversation
…tforms The systray package was missing a stub implementation of showNativeManageAgentsWindow in windows_other.go, causing build failures on Linux and Windows. This adds the no-op stub with the correct signature to match windows_darwin.go.
There was a problem hiding this comment.
Pull request overview
This PR fixes a build failure on non-darwin platforms (Linux and Windows) by adding a missing stub implementation of showNativeManageAgentsWindow to the windows_other.go file. The method was implemented only for darwin in windows_darwin.go, but was being called from platform-agnostic code, causing compilation errors.
Changes:
- Added
showNativeManageAgentsWindowstub method with matching signature towindows_other.go - Added
catalogpackage import to support the new method signature
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The getlantern/systray library requires libayatana-appindicator3-dev and libgtk-3-dev on Linux for building. Added apt-get install steps to all jobs that run on ubuntu-latest.
- Handle os.UserHomeDir() errors in getSystemdUserDir and getXDGAutostartDir - Add #nosec directives for G204 (subprocess) where input is from controlled sources
PowerShell was misinterpreting ./... and coverage.out, causing Go to look for a package called '.out'. Using cmd shell avoids this parsing issue.
- Use os.TempDir() instead of literal /tmp path (gocritic filepathJoin) - Add nolint:errcheck for intentional error ignoring in DisableAutoStart - Properly handle error from isSystemdEnabled - Add nolint:unused for uninstallCLI (reserved for future use)
Owner
Author
|
Thanks for opening this — closing as fully superseded. Every fix this PR
The branch also targets the old module path ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The systray package was missing a stub implementation of
showNativeManageAgentsWindowinwindows_other.go, causing build failures on Linux and Windows.Solution
Added the no-op stub with the correct signature to match
windows_darwin.go.Testing
Fixes the lint error: